Pie widget: UI improvements && bugfixing #778
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Visit the preview URL for this PR (updated for commit 7a73e10): https://cartodb-fb-storybook-react-dev--pr778-feature-pie-widg-pxz53okb.web.app (expires Thu, 12 Oct 2023 16:15:48 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 517cc4d31d7e09cf277774e034094b67c301cd4c |
Pull Request Test Coverage Report for Build 6417555085
💛 - Coveralls |
Comment on lines
+5
to
+8
| - PieWidgetUI: Refactor & New CentralText component [#779](https://github.com/CartoDB/carto-react/pull/779) | ||
| - Pie widget: New ChartLegend component from scratch [#777](https://github.com/CartoDB/carto-react/pull/777) | ||
| - Pie Widget: Add maxNumber of elements + a sorted by size desc by default [#774](https://github.com/CartoDB/carto-react/pull/774) | ||
| - Pie Widget: Add number of selected categories + clear button [#771](https://github.com/CartoDB/carto-react/pull/771) |
There was a problem hiding this comment.
@aaranadev, @menusal we want to land this improved PieWidget very soon. We'll ping you once we have the release, so you can test in PS projs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Shortcut (epic): https://app.shortcut.com/cartoteam/stories/epic/325981/pie-widget-on-builder
Feature branch that consolidates all previous PR's:
Screen.Recording.2023-09-25.at.12.07.12.mov